luchianmihai/walnux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libs/modlib: close fd when error happen

Browse source 
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
This commit is contained in:
dongjiuzhu1 2023-09-08 21:02:46 +08:00 • committed by Xiang Xiao
parent 3017cc4402
commit 13bdaaec99
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
libs/libc/dlfcn/lib_dlopen.c
View file

@ -196,7 +196,7 @@ static inline FAR void *dlinsert(FAR const char *filename)
if (ret != 0)
{
serr("ERROR: Failed to initialize to load module: %d\n", ret);
goto errout_with_lock;
goto errout_with_loadinfo;
}
/* Allocate a module registry entry to hold the module data */
@ -296,7 +296,6 @@ errout_with_registry_entry:
lib_free(modp);
errout_with_loadinfo:
modlib_uninitialize(&loadinfo);
errout_with_lock:
modlib_registry_unlock();
set_errno(-ret);
return NULL;

3
libs/libc/modlib/modlib_init.c
View file

@ -173,8 +173,7 @@ int modlib_initialize(FAR const char *filename,
*/
berr("ERROR: Bad ELF header: %d\n", ret);
return ret;
}
return OK;
return ret;
}

1
libs/libc/modlib/modlib_uninit.c
View file

@ -61,6 +61,7 @@ int modlib_uninitialize(FAR struct mod_loadinfo_s *loadinfo)
if (loadinfo->filfd >= 0)
{
_NX_CLOSE(loadinfo->filfd);
loadinfo->filfd = -1;
}
return OK;