luchianmihai/walnux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

arm64/zynq-mpsoc: fix race condition in txint handler

Browse source 
The tx int handler will call uart_xmitchars() to make a fake interrupt event,
but this is unsafe after enabling interrupts. This PR will add a critical section
to ensure that the txint process will not be interrupted by the IRQ

Signed-off-by: chao an <anchao.archer@bytedance.com>
This commit is contained in:
chao an 2025-07-13 16:44:15 +08:00 • committed by Alan C. Assis
parent b628aec268
commit 382d38b4e0
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
arch/arm64/src/zynq-mpsoc/zynq_serial.c
View file

@ -1024,6 +1024,9 @@ static void zynq_uart_txint(struct uart_dev_s *dev, bool enable)
{
struct zynq_uart_port_s *port = (struct zynq_uart_port_s *)dev->priv;
struct zynq_uart_config *config = &port->config;
irqstate_t flags;
flags = enter_critical_section();
/* Write to Interrupt Enable Register (UART_IER) */
@ -1048,6 +1051,8 @@ static void zynq_uart_txint(struct uart_dev_s *dev, bool enable)
modreg32(XUARTPS_IXR_TXEMPTY, XUARTPS_IXR_TXEMPTY,
config->uart + XUARTPS_IDR_OFFSET);
}
leave_critical_section(flags);
}
/***************************************************************************