luchianmihai/walnux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

risc-v/mpfs: usb: don't try nonexistent ep int flags

Browse source 
Currently the irq handler checks many reserved bits, which is
a waste of resources:

1. pending_rx_ep bit 0 is reserved (always 0)
2. pending_rx_ep and pending_tx_ep have only bits 1, 2, 3 and 4
   defined, no need to scan MPFS_USB_NENDPOINTS (9) bits as the
   rest are reserved

Fix this by checking only the relevant bits.

Signed-off-by: Eero Nurkkala <eero.nurkkala@offcode.fi>
Signed-off-by: Jukka Laitinen <jukka.laitinen@tii.ae>
This commit is contained in:
Eero Nurkkala 2023-11-30 09:38:33 +02:00 • committed by Alan C. Assis
parent 21787b49f0
commit 581d667f72
1 changed files with 15 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
arch/risc-v/src/mpfs/mpfs_usb.c
View file

@ -3467,7 +3467,7 @@ static int mpfs_usb_interrupt(int irq, void *context, void *arg)
if (pending_tx_ep != 0)
{
for (i = 1; i < MPFS_USB_NENDPOINTS; i++)
for (i = 1; i < (MPFS_USB_NENDPOINTS / 2 + 1); i++)
{
if ((pending_tx_ep & (1 << i)) != 0)
{
@ -3478,20 +3478,27 @@ static int mpfs_usb_interrupt(int irq, void *context, void *arg)
if (pending_rx_ep != 0)
{
for (i = 0; i < MPFS_USB_NENDPOINTS; i++)
for (i = 1; i < (MPFS_USB_NENDPOINTS / 2 + 1); i++)
{
/* Check if dead connections are back in business */
if (g_linkdead)
{
/* This releases all, which is a problem if only some
* endpoints are closed on the remote; whereas some
* are functioning; for example ACM and mass storage;
* now the functioning one likely marks the closed ones
* as no longer dead.
/* This releases all tx counterparts with linkdead flag
* set, which is a problem if only some endpoints are
* closed on the remote; whereas some are functioning;
* for example ACM and mass storage; now the functioning
* one likely marks the closed ones as no longer dead.
* Please note that tx counterparts have MPFS_EPIN_START
* offset on top of the rx eps.
*
* For clarity, the eplist[] is as follows:
* eplist: 0: ep0,
* 1-4: ep1rx, ep2rx, ep3rx, ep4rx,
* 5-8: ep1tx, ep2tx, ep3tx, ep4tx
*/
struct mpfs_ep_s *privep = &priv->eplist[i];
struct mpfs_ep_s *privep = &priv->eplist[i + MPFS_EPIN_START];
privep->linkdead = 0;
}