Replace all sprintf with snprintf

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
This commit is contained in:
Xiang Xiao 2023-03-05 22:34:33 +08:00 committed by Alin Jerpelea
parent fa8719bb5a
commit 6f6fce95a2
36 changed files with 120 additions and 84 deletions

View file

@ -302,7 +302,7 @@ struct timer_lowerhalf_s *systick_initialize(bool coreclk,
{ {
char devname[32]; char devname[32];
sprintf(devname, "/dev/timer%d", minor); snprintf(devname, sizeof(devname), "/dev/timer%d", minor);
timer_register(devname, (struct timer_lowerhalf_s *)lower); timer_register(devname, (struct timer_lowerhalf_s *)lower);
} }

View file

@ -302,7 +302,7 @@ struct timer_lowerhalf_s *systick_initialize(bool coreclk,
{ {
char devname[32]; char devname[32];
sprintf(devname, "/dev/timer%d", minor); snprintf(devname, sizeof(devname), "/dev/timer%d", minor);
timer_register(devname, (struct timer_lowerhalf_s *)lower); timer_register(devname, (struct timer_lowerhalf_s *)lower);
} }

View file

@ -250,8 +250,8 @@ static ssize_t wdt_read(struct file *filep, char *buffer, size_t buflen)
wdinfo("buflen=%d\n", buflen); wdinfo("buflen=%d\n", buflen);
if (buflen >= 18) if (buflen >= 18)
{ {
sprintf(buffer, "%08" PRIx32 " %08" PRIx32 "\n", snprintf(buffer, buflen, "%08" PRIx32 " %08" PRIx32 "\n",
c5471_wdt_cntl, c5471_wdt_count); c5471_wdt_cntl, c5471_wdt_count);
return 18; return 18;
} }

View file

@ -165,7 +165,15 @@ int hal_uart_set_tx_buf(UART_INDEX_e uart_index, uint8_t *buf,
uint16_t size); uint16_t size);
int hal_uart_get_tx_ready(UART_INDEX_e uart_index); int hal_uart_get_tx_ready(UART_INDEX_e uart_index);
int hal_uart_send_buff(UART_INDEX_e uart_index, uint8_t *buff, uint16_t len); int hal_uart_send_buff(UART_INDEX_e uart_index, uint8_t *buff, uint16_t len);
#define logx(...) {char tmp_str[128]; sprintf(tmp_str, __VA_ARGS__); hal_uart_send_buff(0, &tmp_str, strlen(tmp_str) + 1);} #define logx(...) \
do \
{ \
char tmp_str[128]; \
snprintf(tmp_str, sizeof(tmp_str), __VA_ARGS__); \
hal_uart_send_buff(0, &tmp_str, strlen(tmp_str) + 1); \
} \
while (0)
int hal_uart_send_byte(UART_INDEX_e uart_index, unsigned char data); int hal_uart_send_byte(UART_INDEX_e uart_index, unsigned char data);
void __attribute__((weak)) hal_UART0_IRQHandler(void); void __attribute__((weak)) hal_UART0_IRQHandler(void);
void __attribute__((weak)) hal_UART1_IRQHandler(void); void __attribute__((weak)) hal_UART1_IRQHandler(void);

View file

@ -292,13 +292,16 @@ static void tlsr82_flash_print(const char *msg, const uint8_t *buf,
{ {
if (i % 16 == 0) if (i % 16 == 0)
{ {
off += sprintf(&print_buf[off], "0x%08x:", i); snprintf(&print_buf[off],
sizeof(print_buf) - off, "0x%08x:", i);
off += strlen(&print_buf[off]);
} }
off += sprintf(&print_buf[off], "0x%02x ", buf[i]); snprintf(&print_buf[off],
i++; sizeof(print_buf) - off, "0x%02x ", buf[i]);
off += strlen(&print_buf[off]);
if (i % 16 == 0) if (++i % 16 == 0)
{ {
ferr("%s\n", print_buf); ferr("%s\n", print_buf);
off = 0; off = 0;
@ -320,7 +323,7 @@ static void tlsr82_flash_print(const char *msg, const uint8_t *buf,
static int tlsr82_flash_test(struct tlsr82_flash_dev_s *priv) static int tlsr82_flash_test(struct tlsr82_flash_dev_s *priv)
{ {
struct mtd_geometry_s geo; struct mtd_geometry_s geo;
int ret = OK; int ret = 0;
int npages = 0; int npages = 0;
int i = 0; int i = 0;
int j = 0; int j = 0;
@ -329,13 +332,16 @@ static int tlsr82_flash_test(struct tlsr82_flash_dev_s *priv)
/* 1. print the manufacture id and unique id */ /* 1. print the manufacture id and unique id */
ret = 0;
ferr("Flash information print:\n"); ferr("Flash information print:\n");
ferr(" Flash MID: 0x%08lx\n", g_flash_mid); ferr(" Flash MID: 0x%08lx\n", g_flash_mid);
ret += sprintf(&print_buf[ret], " Flash UID: "); snprintf(&print_buf[ret],
sizeof(print_buf) - ret, " Flash UID: ");
ret += strlen(&print_buf[ret]);
for (i = 1; i < 16; i++) for (i = 1; i < 16; i++)
{ {
ret += sprintf(&print_buf[ret], "0x%x ", g_flash_uid[i]); snprintf(&print_buf[ret],
sizeof(print_buf) - ret, "0x%x ", g_flash_uid[i]);
ret += strlen(&print_buf[ret]);
} }
ferr("%s\n", print_buf); ferr("%s\n", print_buf);

View file

@ -607,7 +607,7 @@ int esp32c3_partition_init(void)
} }
strlcpy(label, (char *)info->label, sizeof(label)); strlcpy(label, (char *)info->label, sizeof(label));
sprintf(path, "%s%s", path_base, label); snprintf(path, sizeof(path), "%s%s", path_base, label);
finfo("INFO: [label]: %s\n", label); finfo("INFO: [label]: %s\n", label);
finfo("INFO: [type]: %d\n", info->type); finfo("INFO: [type]: %d\n", info->type);

View file

@ -63,7 +63,8 @@ const char *stm32_getchipid_string(void)
for (i = 0, c = 0; i < 12; i++) for (i = 0, c = 0; i < 12; i++)
{ {
sprintf(&cpuid[c], "%02X", getreg8(0x1ffff7e8 + 11 - i)); snprintf(&cpuid[c], sizeof(cpuid) - c,
"%02X", getreg8(0x1ffff7e8 + 11 - i));
c += 2; c += 2;
if (i % 4 == 3) if (i % 4 == 3)
{ {

View file

@ -63,7 +63,8 @@ const char *stm32_getchipid_string(void)
for (i = 0, c = 0; i < 12; i++) for (i = 0, c = 0; i < 12; i++)
{ {
sprintf(&cpuid[c], "%02X", getreg8(0x1ffff7e8 + 11 - i)); snprintf(&cpuid[c], sizeof(cpuid) - c,
"%02X", getreg8(0x1ffff7e8 + 11 - i));
c += 2; c += 2;
if (i % 4 == 3) if (i % 4 == 3)
{ {

View file

@ -174,7 +174,7 @@ int stm32_bringup(void)
char buf[9]; char buf[9];
#ifdef CONFIG_STM32F7_TIM1_QE #ifdef CONFIG_STM32F7_TIM1_QE
sprintf(buf, "/dev/qe0"); snprintf(buf, sizeof(buf), "/dev/qe0");
ret = stm32_qencoder_initialize(buf, 1); ret = stm32_qencoder_initialize(buf, 1);
if (ret < 0) if (ret < 0)
{ {
@ -186,7 +186,7 @@ int stm32_bringup(void)
#endif #endif
#ifdef CONFIG_STM32F7_TIM3_QE #ifdef CONFIG_STM32F7_TIM3_QE
sprintf(buf, "/dev/qe2"); snprintf(buf, sizeof(buf), "/dev/qe2");
ret = stm32_qencoder_initialize(buf, 3); ret = stm32_qencoder_initialize(buf, 3);
if (ret < 0) if (ret < 0)
{ {
@ -198,7 +198,7 @@ int stm32_bringup(void)
#endif #endif
#ifdef CONFIG_STM32F7_TIM4_QE #ifdef CONFIG_STM32F7_TIM4_QE
sprintf(buf, "/dev/qe3"); snprintf(buf, sizeof(buf), "/dev/qe3");
ret = stm32_qencoder_initialize(buf, 4); ret = stm32_qencoder_initialize(buf, 4);
if (ret < 0) if (ret < 0)
{ {

View file

@ -316,7 +316,7 @@ int board_app_initialize(uintptr_t arg)
index = 0; index = 0;
#ifdef CONFIG_STM32L4_TIM1_QE #ifdef CONFIG_STM32L4_TIM1_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 1); ret = stm32l4_qencoder_initialize(buf, 1);
if (ret != OK) if (ret != OK)
{ {
@ -327,7 +327,7 @@ int board_app_initialize(uintptr_t arg)
#endif #endif
#ifdef CONFIG_STM32L4_TIM2_QE #ifdef CONFIG_STM32L4_TIM2_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 2); ret = stm32l4_qencoder_initialize(buf, 2);
if (ret != OK) if (ret != OK)
{ {
@ -338,7 +338,7 @@ int board_app_initialize(uintptr_t arg)
#endif #endif
#ifdef CONFIG_STM32L4_TIM3_QE #ifdef CONFIG_STM32L4_TIM3_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 3); ret = stm32l4_qencoder_initialize(buf, 3);
if (ret != OK) if (ret != OK)
{ {
@ -349,7 +349,7 @@ int board_app_initialize(uintptr_t arg)
#endif #endif
#ifdef CONFIG_STM32L4_TIM4_QE #ifdef CONFIG_STM32L4_TIM4_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 4); ret = stm32l4_qencoder_initialize(buf, 4);
if (ret != OK) if (ret != OK)
{ {
@ -360,7 +360,7 @@ int board_app_initialize(uintptr_t arg)
#endif #endif
#ifdef CONFIG_STM32L4_TIM5_QE #ifdef CONFIG_STM32L4_TIM5_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 5); ret = stm32l4_qencoder_initialize(buf, 5);
if (ret != OK) if (ret != OK)
{ {
@ -371,7 +371,7 @@ int board_app_initialize(uintptr_t arg)
#endif #endif
#ifdef CONFIG_STM32L4_TIM8_QE #ifdef CONFIG_STM32L4_TIM8_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 8); ret = stm32l4_qencoder_initialize(buf, 8);
if (ret != OK) if (ret != OK)
{ {

View file

@ -318,7 +318,7 @@ int board_app_initialize(uintptr_t arg)
index = 0; index = 0;
#ifdef CONFIG_STM32L4_TIM1_QE #ifdef CONFIG_STM32L4_TIM1_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 1); ret = stm32l4_qencoder_initialize(buf, 1);
if (ret < 0) if (ret < 0)
{ {
@ -329,7 +329,7 @@ int board_app_initialize(uintptr_t arg)
#endif #endif
#ifdef CONFIG_STM32L4_TIM2_QE #ifdef CONFIG_STM32L4_TIM2_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 2); ret = stm32l4_qencoder_initialize(buf, 2);
if (ret < 0) if (ret < 0)
{ {
@ -340,7 +340,7 @@ int board_app_initialize(uintptr_t arg)
#endif #endif
#ifdef CONFIG_STM32L4_TIM3_QE #ifdef CONFIG_STM32L4_TIM3_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 3); ret = stm32l4_qencoder_initialize(buf, 3);
if (ret < 0) if (ret < 0)
{ {
@ -351,7 +351,7 @@ int board_app_initialize(uintptr_t arg)
#endif #endif
#ifdef CONFIG_STM32L4_TIM4_QE #ifdef CONFIG_STM32L4_TIM4_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 4); ret = stm32l4_qencoder_initialize(buf, 4);
if (ret < 0) if (ret < 0)
{ {
@ -362,7 +362,7 @@ int board_app_initialize(uintptr_t arg)
#endif #endif
#ifdef CONFIG_STM32L4_TIM5_QE #ifdef CONFIG_STM32L4_TIM5_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 5); ret = stm32l4_qencoder_initialize(buf, 5);
if (ret < 0) if (ret < 0)
{ {
@ -373,7 +373,7 @@ int board_app_initialize(uintptr_t arg)
#endif #endif
#ifdef CONFIG_STM32L4_TIM8_QE #ifdef CONFIG_STM32L4_TIM8_QE
sprintf(buf, "/dev/qe%d", index++); snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
ret = stm32l4_qencoder_initialize(buf, 8); ret = stm32l4_qencoder_initialize(buf, 8);
if (ret < 0) if (ret < 0)
{ {

View file

@ -86,7 +86,7 @@ int sim_foc_setup(void)
/* Get devpath for FOC */ /* Get devpath for FOC */
sprintf(devpath, "/dev/foc%d", i); snprintf(devpath, sizeof(devpath), "/dev/foc%d", i);
/* Register FOC device */ /* Register FOC device */

View file

@ -1391,7 +1391,7 @@ int mfrc522_selftest(FAR struct mfrc522_dev_s *dev)
{ {
for (j = 0, k = 0; j < 8; j++, k += 3) for (j = 0, k = 0; j < 8; j++, k += 3)
{ {
sprintf(&outbuf[k], " %02x", result[i + j]); snprintf(&outbuf[k], sizeof(outbuf) - k, " %02x", result[i + j]);
} }
ctlsinfo(" %02x:%s\n", i, outbuf); ctlsinfo(" %02x:%s\n", i, outbuf);

View file

@ -3900,7 +3900,9 @@ retry:
{ {
for (j = 0, k = 0; j < 8 && j < remaining ; j++) for (j = 0, k = 0; j < 8 && j < remaining ; j++)
{ {
k += sprintf(&buffer[k], "%12d", dev->freecount[i + j]); snprintf(&buffer[k], sizeof(buffer) - k,
"%12d", dev->freecount[i + j]);
k += strlen(&buffer[k]);
} }
ferr("%04x:%s\n", i, buffer); ferr("%04x:%s\n", i, buffer);

View file

@ -373,8 +373,8 @@ static int net_rpmsg_drv_sockioctl_handler(FAR struct rpmsg_endpoint *ept,
/* Save pointers into argv */ /* Save pointers into argv */
sprintf(arg1, "%p", ept); snprintf(arg1, sizeof(arg1), "%p", ept);
sprintf(arg2, "%p", data); snprintf(arg2, sizeof(arg2), "%p", data);
argv[0] = arg1; argv[0] = arg1;
argv[1] = arg2; argv[1] = arg2;
@ -565,7 +565,8 @@ static void net_rpmsg_drv_device_created(FAR struct rpmsg_device *rdev,
if (!strcmp(priv->cpuname, rpmsg_get_cpuname(rdev))) if (!strcmp(priv->cpuname, rpmsg_get_cpuname(rdev)))
{ {
priv->ept.priv = dev; priv->ept.priv = dev;
sprintf(eptname, NET_RPMSG_EPT_NAME, priv->devname); snprintf(eptname, sizeof(eptname),
NET_RPMSG_EPT_NAME, priv->devname);
rpmsg_create_ept(&priv->ept, rdev, eptname, rpmsg_create_ept(&priv->ept, rdev, eptname,
RPMSG_ADDR_ANY, RPMSG_ADDR_ANY, RPMSG_ADDR_ANY, RPMSG_ADDR_ANY,

View file

@ -121,7 +121,7 @@ void lib_rttoutstream_open(FAR struct lib_rttoutstream_s *stream,
bufsize = bufsize ? bufsize : BUFFER_SIZE_UP; bufsize = bufsize ? bufsize : BUFFER_SIZE_UP;
stream->buffer = (FAR char *)kmm_malloc(bufsize); stream->buffer = (FAR char *)kmm_malloc(bufsize);
DEBUGASSERT(stream->buffer); DEBUGASSERT(stream->buffer);
sprintf(stream->name, "rtt%d", channel); snprintf(stream->name, sizeof(stream->name), "rtt%d", channel);
SEGGER_RTT_ConfigUpBuffer(channel, stream->name, stream->buffer, SEGGER_RTT_ConfigUpBuffer(channel, stream->name, stream->buffer,
bufsize, SEGGER_RTT_MODE_DEFAULT); bufsize, SEGGER_RTT_MODE_DEFAULT);
} }
@ -169,7 +169,7 @@ void lib_rttinstream_open(FAR struct lib_rttinstream_s *stream,
bufsize = bufsize ? bufsize : BUFFER_SIZE_DOWN; bufsize = bufsize ? bufsize : BUFFER_SIZE_DOWN;
stream->buffer = (FAR char *)kmm_malloc(bufsize); stream->buffer = (FAR char *)kmm_malloc(bufsize);
DEBUGASSERT(stream->buffer); DEBUGASSERT(stream->buffer);
sprintf(stream->name, "rtt%d", channel); snprintf(stream->name, sizeof(stream->name), "rtt%d", channel);
SEGGER_RTT_ConfigDownBuffer(channel, stream->name, stream->buffer, SEGGER_RTT_ConfigDownBuffer(channel, stream->name, stream->buffer,
bufsize, SEGGER_RTT_MODE_DEFAULT); bufsize, SEGGER_RTT_MODE_DEFAULT);
} }

View file

@ -323,7 +323,8 @@ static void uart_rpmsg_device_created(FAR struct rpmsg_device *rdev,
if (strcmp(priv->cpuname, rpmsg_get_cpuname(rdev)) == 0) if (strcmp(priv->cpuname, rpmsg_get_cpuname(rdev)) == 0)
{ {
priv->ept.priv = dev; priv->ept.priv = dev;
sprintf(eptname, "%s%s", UART_RPMSG_EPT_PREFIX, priv->devname); snprintf(eptname, sizeof(eptname), "%s%s",
UART_RPMSG_EPT_PREFIX, priv->devname);
rpmsg_create_ept(&priv->ept, rdev, eptname, rpmsg_create_ept(&priv->ept, rdev, eptname,
RPMSG_ADDR_ANY, RPMSG_ADDR_ANY, RPMSG_ADDR_ANY, RPMSG_ADDR_ANY,
uart_rpmsg_ept_cb, NULL); uart_rpmsg_ept_cb, NULL);
@ -451,7 +452,8 @@ int uart_rpmsg_init(FAR const char *cpuname, FAR const char *devname,
} }
nxmutex_init(&priv->lock); nxmutex_init(&priv->lock);
sprintf(dev_name, "%s%s", UART_RPMSG_DEV_PREFIX, devname); snprintf(dev_name, sizeof(dev_name), "%s%s",
UART_RPMSG_DEV_PREFIX, devname);
uart_register(dev_name, dev); uart_register(dev_name, dev);
if (dev->isconsole) if (dev->isconsole)

View file

@ -2408,7 +2408,7 @@ int usbdev_serialinitialize(int minor)
/* Register the single port supported by this implementation */ /* Register the single port supported by this implementation */
sprintf(devname, "/dev/ttyUSB%d", minor); snprintf(devname, sizeof(devname), "/dev/ttyUSB%d", minor);
ret = uart_register(devname, &priv->serdev); ret = uart_register(devname, &priv->serdev);
if (ret) if (ret)
{ {

View file

@ -862,7 +862,7 @@ void cc1101_dumpregs(struct cc1101_dev_s *dev, uint8_t addr, uint8_t length)
for (i = 0, j = 0; i < readsize; i++, j += 3) for (i = 0, j = 0; i < readsize; i++, j += 3)
{ {
sprintf(&outbuf[j], " %02x", regbuf[i]); snprintf(&outbuf[j], sizeof(outbuf) - j, " %02x", regbuf[i]);
} }
/* Dump the formatted data to the syslog output */ /* Dump the formatted data to the syslog output */

View file

@ -62,9 +62,10 @@ void bcmf_hexdump(FAR uint8_t *data, unsigned int len, unsigned long offset)
char_count = 0; char_count = 0;
} }
sprintf(hex_line + 3 * char_count, "%02x ", data[i]); snprintf(hex_line + 3 * char_count, sizeof(hex_line) - 3 * char_count,
sprintf(char_line + char_count, "%c", "%02x ", data[i]);
data[i] < 0x20 || data[i] >= 0x7f? '.': data[i]); snprintf(char_line + char_count, sizeof(char_line) - char_count,
"%c", data[i] < 0x20 || data[i] >= 0x7f? '.' : data[i]);
char_count++; char_count++;
} }

View file

@ -1302,12 +1302,15 @@ static int at86rf23x_regdump(FAR struct at86rf23x_dev_s *dev)
if ((i & 0x0f) == 0) if ((i & 0x0f) == 0)
{ {
len = sprintf(buf, "%02x: ", i & 0xff); snprintf(buf, sizeof(buf), "%02x: ", i & 0xff);
len = strlen(buf);
} }
/* Print the register value */ /* Print the register value */
len += sprintf(buf + len, "%02x ", at86rf23x_getreg(dev->spi, i)); snprintf(buf + len, sizeof(buf) - len,
"%02x ", at86rf23x_getreg(dev->spi, i));
len += strlen(buf + len);
/* At the end of each 15 regs or end of rf233s regs and actually print /* At the end of each 15 regs or end of rf233s regs and actually print
* debug message. * debug message.
@ -1315,7 +1318,7 @@ static int at86rf23x_regdump(FAR struct at86rf23x_dev_s *dev)
if ((i & 15) == 15 || i == 0x2f) if ((i & 15) == 15 || i == 0x2f)
{ {
sprintf(buf + len, "\n"); snprintf(buf + len, sizeof(buf) - len, "\n");
wlinfo("%s", buf); wlinfo("%s", buf);
} }
} }

View file

@ -142,13 +142,16 @@ int mrf24j40_regdump(FAR struct mrf24j40_radio_s *dev)
{ {
if ((i & 15) == 0) if ((i & 15) == 0)
{ {
len = sprintf(buf, "%02" PRIx32 ": ", i & 0xff); snprintf(buf, sizeof(buf), "%02" PRIx32 ": ", i & 0xff);
len = strlen(buf);
} }
len += sprintf(buf + len, "%02x ", mrf24j40_getreg(dev->spi, i)); snprintf(buf + len, sizeof(buf) - len,
"%02x ", mrf24j40_getreg(dev->spi, i));
len += strlen(buf + len);
if ((i & 15) == 15) if ((i & 15) == 15)
{ {
sprintf(buf + len, "\n"); snprintf(buf + len, sizeof(buf) - len, "\n");
wlinfo("%s", buf); wlinfo("%s", buf);
} }
} }
@ -159,13 +162,16 @@ int mrf24j40_regdump(FAR struct mrf24j40_radio_s *dev)
{ {
if ((i & 15) == 0) if ((i & 15) == 0)
{ {
len = sprintf(buf, "%02" PRIx32 ": ", i & 0xff); snprintf(buf, sizeof(buf), "%02" PRIx32 ": ", i & 0xff);
len = strlen(buf);
} }
len += sprintf(buf + len, "%02x ", mrf24j40_getreg(dev->spi, i)); snprintf(buf + len, sizeof(buf) - len,
"%02x ", mrf24j40_getreg(dev->spi, i));
len += strlen(buf + len);
if ((i & 15) == 15) if ((i & 15) == 15)
{ {
sprintf(buf + len, "\n"); snprintf(buf + len, sizeof(buf) - len, "\n");
wlinfo("%s", buf); wlinfo("%s", buf);
} }
} }

View file

@ -210,8 +210,8 @@ static void nrf24l01_worker(FAR void *arg);
#endif #endif
#ifdef CONFIG_DEBUG_WIRELESS #ifdef CONFIG_DEBUG_WIRELESS
static void binarycvt(FAR char *deststr, FAR const uint8_t *srcbin, static void binarycvt(FAR char *deststr, size_t destlen,
size_t srclen); FAR const uint8_t *srcbin, size_t srclen);
#endif #endif
/* POSIX API */ /* POSIX API */
@ -912,13 +912,13 @@ out:
****************************************************************************/ ****************************************************************************/
#ifdef CONFIG_DEBUG_WIRELESS #ifdef CONFIG_DEBUG_WIRELESS
static void binarycvt(FAR char *deststr, FAR const uint8_t *srcbin, static void binarycvt(FAR char *deststr, size_t destlen,
size_t srclen) FAR const uint8_t *srcbin, size_t srclen)
{ {
int i = 0; int i = 0;
while (i < srclen) while (i < srclen && 2 * (i + 1) < destlen)
{ {
sprintf(deststr + i * 2, "%02x", srcbin[i]); snprintf(deststr + i * 2, destlen - i * 2, "%02x", srcbin[i]);
++i; ++i;
} }
@ -2084,7 +2084,7 @@ void nrf24l01_dumpregs(FAR struct nrf24l01_dev_s *dev)
nrf24l01_readregbyte(dev, NRF24L01_OBSERVE_TX)); nrf24l01_readregbyte(dev, NRF24L01_OBSERVE_TX));
nrf24l01_readreg(dev, NRF24L01_TX_ADDR, addr, dev->addrlen); nrf24l01_readreg(dev, NRF24L01_TX_ADDR, addr, dev->addrlen);
binarycvt(addrstr, addr, dev->addrlen); binarycvt(addrstr, sizeof(addrstr), addr, dev->addrlen);
syslog(LOG_INFO, "TX_ADDR: %s\n", addrstr); syslog(LOG_INFO, "TX_ADDR: %s\n", addrstr);
syslog(LOG_INFO, "CD: %02x\n", syslog(LOG_INFO, "CD: %02x\n",

View file

@ -87,7 +87,7 @@ static void spirit_dump_buffer(FAR const uint8_t *buffer, unsigned int buflen)
*ptr++ = ' '; *ptr++ = ' ';
} }
sprintf(ptr, "%02x ", *buffer++); snprintf(ptr, sizeof(outbuf) - (ptr - outbuf), "%02x ", *buffer++);
ptr += 3; ptr += 3;
} }

View file

@ -55,7 +55,7 @@ struct inode_path_s
{ {
foreach_inode_t handler; foreach_inode_t handler;
FAR void *arg; FAR void *arg;
char path[CONFIG_PATH_MAX]; char path[PATH_MAX];
}; };
/**************************************************************************** /****************************************************************************
@ -110,7 +110,7 @@ static int foreach_inodelevel(FAR struct inode *node,
/* Make sure that this would not exceed the maximum path length */ /* Make sure that this would not exceed the maximum path length */
if (pathlen + namlen > PATH_MAX) if (pathlen + namlen >= PATH_MAX)
{ {
ret = -ENAMETOOLONG; ret = -ENAMETOOLONG;
break; break;
@ -118,7 +118,8 @@ static int foreach_inodelevel(FAR struct inode *node,
/* Append the path segment to this inode and recurse */ /* Append the path segment to this inode and recurse */
sprintf(&info->path[pathlen], "/%s", node->i_name); snprintf(&info->path[pathlen], sizeof(info->path) - pathlen,
"/%s", node->i_name);
ret = foreach_inodelevel(node->i_child, info); ret = foreach_inodelevel(node->i_child, info);
/* Truncate the path name back to the correct length */ /* Truncate the path name back to the correct length */

View file

@ -857,7 +857,8 @@ FAR void *automount_initialize(FAR const struct automount_lower_s *lower)
/* Register driver */ /* Register driver */
sprintf(devpath, CONFIG_FS_AUTOMOUNTER_VFS_PATH "%s", lower->mountpoint); snprintf(devpath, sizeof(devpath),
CONFIG_FS_AUTOMOUNTER_VFS_PATH "%s", lower->mountpoint);
ret = register_driver(devpath, &g_automount_fops, 0444, priv); ret = register_driver(devpath, &g_automount_fops, 0444, priv);
if (ret < 0) if (ret < 0)
@ -918,8 +919,8 @@ void automount_uninitialize(FAR void *handle)
{ {
char devpath[PATH_MAX]; char devpath[PATH_MAX];
sprintf(devpath, CONFIG_FS_AUTOMOUNTER_VFS_PATH "%s", snprintf(devpath, sizeof(devpath),
lower->mountpoint); CONFIG_FS_AUTOMOUNTER_VFS_PATH "%s", lower->mountpoint);
unregister_driver(devpath); unregister_driver(devpath);
} }

View file

@ -96,7 +96,7 @@ static int mountpoint_filter(FAR struct inode *node,
/* Append the inode name to the directory path */ /* Append the inode name to the directory path */
sprintf(&dirpath[pathlen], "/%s", node->i_name); snprintf(&dirpath[pathlen], PATH_MAX - pathlen, "/%s", node->i_name);
/* Get the status of the file system */ /* Get the status of the file system */

View file

@ -80,7 +80,7 @@ static inline void nxmu_connect(FAR struct nxmu_conn_s *conn)
/* Create the client MQ name */ /* Create the client MQ name */
sprintf(mqname, NX_CLIENT_MQNAMEFMT, conn->cid); snprintf(mqname, sizeof(mqname), NX_CLIENT_MQNAMEFMT, conn->cid);
/* Open the client MQ -- this should have already been created by the /* Open the client MQ -- this should have already been created by the
* client * client

View file

@ -204,7 +204,7 @@ static inline int bt_addr_le_to_str(FAR const bt_addr_le_t *addr, char *str,
break; break;
default: default:
sprintf(type, "0x%02x", addr->type); snprintf(type, sizeof(type), "0x%02x", addr->type);
break; break;
} }

View file

@ -220,7 +220,7 @@ FAR char *envpath_next(ENVPATH_HANDLE handle, FAR const char *relpath)
/* Construct the full path */ /* Construct the full path */
sprintf(fullpath, "%s/%s", path, relpath); snprintf(fullpath, pathlen, "%s/%s", path, relpath);
/* Verify that a regular file exists at this path */ /* Verify that a regular file exists at this path */

View file

@ -116,7 +116,7 @@ NXHANDLE nx_connectinstance(FAR const char *svrmqname)
conn->cid = g_nxcid++; conn->cid = g_nxcid++;
nxmutex_unlock(&g_nxliblock); nxmutex_unlock(&g_nxliblock);
sprintf(climqname, NX_CLIENT_MQNAMEFMT, conn->cid); snprintf(climqname, sizeof(climqname), NX_CLIENT_MQNAMEFMT, conn->cid);
/* Open the client MQ for reading */ /* Open the client MQ for reading */

View file

@ -503,8 +503,9 @@ void mempool_memdump(FAR struct mempool_s *pool, pid_t pid)
# if CONFIG_MM_BACKTRACE > 0 # if CONFIG_MM_BACKTRACE > 0
for (i = 0; i < CONFIG_MM_BACKTRACE && buf->backtrace[i]; i++) for (i = 0; i < CONFIG_MM_BACKTRACE && buf->backtrace[i]; i++)
{ {
sprintf(bt + i * MM_PTR_FMT_WIDTH, format, snprintf(bt + i * MM_PTR_FMT_WIDTH,
MM_PTR_FMT_WIDTH - 1, buf->backtrace[i]); sizeof(bt) - i * MM_PTR_FMT_WIDTH,
format, MM_PTR_FMT_WIDTH - 1, buf->backtrace[i]);
} }
# endif # endif

View file

@ -80,8 +80,9 @@ static void memdump_handler(FAR struct mm_allocnode_s *node, FAR void *arg)
# if CONFIG_MM_BACKTRACE > 0 # if CONFIG_MM_BACKTRACE > 0
for (i = 0; i < CONFIG_MM_BACKTRACE && node->backtrace[i]; i++) for (i = 0; i < CONFIG_MM_BACKTRACE && node->backtrace[i]; i++)
{ {
sprintf(buf + i * MM_PTR_FMT_WIDTH, format, snprintf(buf + i * MM_PTR_FMT_WIDTH,
MM_PTR_FMT_WIDTH - 1, node->backtrace[i]); sizeof(buf) - i * MM_PTR_FMT_WIDTH,
format, MM_PTR_FMT_WIDTH - 1, node->backtrace[i]);
} }
# endif # endif

View file

@ -422,8 +422,9 @@ static void memdump_handler(FAR void *ptr, size_t size, int used,
# if CONFIG_MM_BACKTRACE > 0 # if CONFIG_MM_BACKTRACE > 0
for (i = 0; i < CONFIG_MM_BACKTRACE && dump->backtrace[i]; i++) for (i = 0; i < CONFIG_MM_BACKTRACE && dump->backtrace[i]; i++)
{ {
sprintf(buf + i * MM_PTR_FMT_WIDTH, format, snprintf(buf + i * MM_PTR_FMT_WIDTH,
MM_PTR_FMT_WIDTH - 1, dump->backtrace[i]); sizeof(buf) - i * MM_PTR_FMT_WIDTH,
format, MM_PTR_FMT_WIDTH - 1, dump->backtrace[i]);
} }
# endif # endif

View file

@ -67,11 +67,11 @@ static void neighbor_dump_address(FAR const void *buf, unsigned int buflen)
{ {
if (i == 0) if (i == 0)
{ {
sprintf(outbuf, " at: "); snprintf(outbuf, sizeof(outbuf), " at: ");
} }
else else
{ {
sprintf(outbuf, " "); snprintf(outbuf, sizeof(outbuf), " ");
} }
maxj = 16; maxj = 16;
@ -89,7 +89,7 @@ static void neighbor_dump_address(FAR const void *buf, unsigned int buflen)
*ptr++ = ' '; *ptr++ = ' ';
} }
sprintf(ptr, "%02x ", *buffer++); snprintf(ptr, sizeof(outbuf) - (ptr - outbuf), "%02x ", *buffer++);
ptr += 3; ptr += 3;
} }

View file

@ -184,7 +184,7 @@ int setenv(FAR const char *name, FAR const char *value, int overwrite)
/* Now, put the new name=value string into the environment buffer */ /* Now, put the new name=value string into the environment buffer */
sprintf(pvar, "%s=%s", name, value); snprintf(pvar, varlen, "%s=%s", name, value);
sched_unlock(); sched_unlock();
return OK; return OK;