From 84c887f48c3aa586d5daee332eb0286b31dffb9f Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Sat, 29 Apr 2017 15:53:23 -0600 Subject: [PATCH] Update a README and some comments. --- configs/nucleo-f072rb/README.txt | 30 +++++------------------------- include/nuttx/spi/spi.h | 7 ++++--- 2 files changed, 9 insertions(+), 28 deletions(-) diff --git a/configs/nucleo-f072rb/README.txt b/configs/nucleo-f072rb/README.txt index de1713e5ab..3f17cedb85 100644 --- a/configs/nucleo-f072rb/README.txt +++ b/configs/nucleo-f072rb/README.txt @@ -17,32 +17,12 @@ Contents Status ====== - 2017-04-27: There are many problems. On start up, I have to reset - several times before I get NSH prompt (or parts of it). Apparently the - STM32 is either hanging (perhaps in clockconfig()) or perhaps it has - taken a hard fault before it is able to generate debug output? + 2017-04-28: After struggling with some clock configuration and FLASH wait + state issues, the board now boots and the basic NSH configurations works + without problem. - There are many hardfaults during initial serial output. This change - seems to eliminate those hardfaults: - - @@ -2163,7 +2163,7 @@ static void stm32f0serial_txint(FAR struct uart_dev_s *dev, bool enable) - * interrupts disabled (note this may recurse). - */ - - - uart_xmitchars(dev); - +// uart_xmitchars(dev); - #endif - } - else - - Which implies that the hardfaults are due to runaway recursion in the - serial driver? This suggest some error in either determining when there - is TX data available or in disabling TX interrupts. - - But this not a solution. Even without the hard faults, it may hang - attempting to output the NSH greeting and prompt or hang unable to - receive input. These symptoms suggest some issue with TX and RX - interrupt handling. + A USB device driver was added along with support for clocking from the + HSI48. That driver remains untested. Nucleo-64 Boards ================ diff --git a/include/nuttx/spi/spi.h b/include/nuttx/spi/spi.h index ffff5e2911..ddeb222635 100644 --- a/include/nuttx/spi/spi.h +++ b/include/nuttx/spi/spi.h @@ -432,9 +432,10 @@ #define SPIDEVID_TYPE (devid) (((uint32_t)(devid) >> 16) & 0xffff) #define SPIDEVID_INDEX(devid) ((uint32_t)(devid) & 0xffff) -/* These are replacement definitions for the currently used SPI device indexes. - * The argument, n, is the instance number. This should be zero is there is - * only one instance of the SPI device on the bus. +/* These are standard definitions for the defined SPI device IDs. The index + * argument, n, is the instance number. This should be zero if there is + * only one instance of the SPI device on the SPI bus. Indices greater than + * zero discriminate the additional devices of the same type on the SPI bus. */ #define SPIDEV_NONE(n) SPIDEV_ID(SPIDEVTYPE_NONE, (n))