From aefacb05ca29fbcd19549a127647cdb4dab4d0fd Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Fri, 8 Mar 2019 08:43:16 -0600 Subject: [PATCH] Minor NxTerm-related clean-up --- configs/open1788/README.txt | 3 ++- graphics/nxterm/nxterm_scroll.c | 2 -- libs/libnx/nxfonts/nxfonts_cache.c | 3 ++- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configs/open1788/README.txt b/configs/open1788/README.txt index fcba9d4cda..c6ef871418 100644 --- a/configs/open1788/README.txt +++ b/configs/open1788/README.txt @@ -408,7 +408,8 @@ Configuration Directories STATUS: 2019-03-08: Currently I am seeing a problem. The display looks good until it begins scrolling when the display is full. Then there are - missing characters. + missing characters. This is probably related to clearing of the final + line of the display after the scroll(?) nsh --- diff --git a/graphics/nxterm/nxterm_scroll.c b/graphics/nxterm/nxterm_scroll.c index e183b1447e..c1d3e62d1a 100644 --- a/graphics/nxterm/nxterm_scroll.c +++ b/graphics/nxterm/nxterm_scroll.c @@ -210,8 +210,6 @@ void nxterm_scroll(FAR struct nxterm_state_s *priv, int scrollheight) */ priv->nchars--; - priv->bm[priv->nchars].code = ' '; - priv->bm[priv->nchars].flags = BMFLAGS_NOGLYPH; } /* No.. just decrement its vertical position (moving it "up" the diff --git a/libs/libnx/nxfonts/nxfonts_cache.c b/libs/libnx/nxfonts/nxfonts_cache.c index 1334276cf6..604c3abb6f 100644 --- a/libs/libnx/nxfonts/nxfonts_cache.c +++ b/libs/libnx/nxfonts/nxfonts_cache.c @@ -542,7 +542,8 @@ nxf_renderglyph(FAR struct nxfonts_fcache_s *priv, /* Allocate the glyph (always succeeds) */ bmsize = stride * height; - glyph = (FAR struct nxfonts_glyph_s *)lib_malloc(SIZEOF_NXFONTS_GLYPH_S(bmsize)); + glyph = (FAR struct nxfonts_glyph_s *) + lib_malloc(SIZEOF_NXFONTS_GLYPH_S(bmsize)); if (glyph != NULL) {