luchianmihai/walnux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libc/fdcheck: cause system to panic when a double close occurs

Browse source 
There are many close calls in application without checking return value,
and wrong code causes the same fd to be closed multi times, we should detect
this situation and avoud effecting the fd in other threads.

Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
This commit is contained in:
dongjiuzhu1 2025-03-10 14:09:59 +08:00 • committed by Xiang Xiao
parent 486dabdd2d
commit e2148c513b
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
libs/libc/misc/lib_fdcheck.c
View file

@ -63,6 +63,7 @@ static uint8_t g_fdcheck_tag = 0;
int fdcheck_restore(int val)
{
uint8_t tag_store;
int ret;
int fd;
/* If val is a bare fd（0~255）, we should return it directly */
@ -73,7 +74,7 @@ int fdcheck_restore(int val)
return val;
}
int ret = ioctl(fd, FIOC_GETTAG_FDCHECK, &tag_store);
ret = ioctl(fd, FIOC_GETTAG_FDCHECK, &tag_store);
if (ret >= 0)
{
uint8_t tag_expect = (val >> TAG_SHIFT) & TAG_MASK;
@ -84,6 +85,12 @@ int fdcheck_restore(int val)
PANIC();
}
}
else
{
ferr("fd is bad, or fd have already been closed, errno:%d",
get_errno());
PANIC();
}
return fd;
}