luchianmihai/walnux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mpfs_irq.c: Interrupt claim must be cleared before disabling the source

Browse source 
From Polarfire SoC TRM:

6.5.8 Interrupt Completion

To signal the completion of executing an interrupt handler, the processor core writes the received interrupt ID to the
Claim/Complete register. The PLIC does not check whether the completion ID is the same as the last claim ID for that
target. If the completion ID does not match an interrupt source that is currently enabled for the target, the completion
is ignored.

The last paragraph clearly states that IRQ completion does not work for
sources that have been disabled -> must ACK the completion before disable.

Signed-off-by: Ville Juven <ville.juven@unikie.com>
This commit is contained in:
Ville Juven 2025-02-18 11:14:05 +02:00 • committed by Alan C. Assis
parent 8de9dd9515
commit ff4d461fda
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
arch/risc-v/src/mpfs/mpfs_irq.c
View file

@ -133,13 +133,22 @@ void up_disable_irq(int irq)
uintptr_t claim_address =
mpfs_plic_get_claimbase(riscv_cpuid_to_hartid(i));
/* Clear any already claimed IRQ (this must be done BEFORE
* disabling the interrupt source):
*
* To signal the completion of executing an interrupt handler, the
* processor core writes the received interrupt ID to the
* Claim/Complete register. The PLIC does not check whether the
* completion ID is the same as the last claim ID for that target.
* If the completion ID does not match an interrupt source that is
* currently enabled for the target, the completion is ignored.
*/
putreg32(extirq, claim_address);
/* Clear enable bit for the irq */
modifyreg32(iebase + (4 * (extirq / 32)), 1 << (extirq % 32), 0);
/* Clear any already claimed IRQ */
putreg32(extirq, claim_address);
}
}
}