e4d5c78008
When using pthread_kill, the signal should be delivered to the specified thread. Current implementation, however, may add the signal to the groups pending list, if the signal is masked at the time of dispatch. From the group's pending list it can be delivered to any thread of the group, which is wrong. Fix this by adding a new field "FAR struct tcb_s *tcb" to "struct sigpendq", marking if the signal needs to be delivered to a specific thread. Use NULL for the value if delivery to any thread in the group is ok. Signed-off-by: Jukka Laitinen <jukka.laitinen@tii.ae>
149 lines
5 KiB
C
149 lines
5 KiB
C
/****************************************************************************
|
|
* sched/signal/sig_tgkill.c
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed with
|
|
* this work for additional information regarding copyright ownership. The
|
|
* ASF licenses this file to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the
|
|
* License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Included Files
|
|
****************************************************************************/
|
|
|
|
#include <nuttx/config.h>
|
|
|
|
#include <signal.h>
|
|
#include <errno.h>
|
|
|
|
#include <nuttx/sched.h>
|
|
#include <nuttx/signal.h>
|
|
|
|
#include "sched/sched.h"
|
|
#include "signal/signal.h"
|
|
|
|
/****************************************************************************
|
|
* Public Functions
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Name: nxsig_tgkill
|
|
*
|
|
* Description:
|
|
* The tgkill() system call can be used to send any signal to a thread.
|
|
* See kill() for further information as this is just a simple wrapper
|
|
* around the kill() function.
|
|
*
|
|
* Input Parameters:
|
|
* gid - The id of the task to receive the signal.
|
|
* tid - The id of the thread to receive the signal. Only positive,
|
|
* non-zero values of 'tid' are supported.
|
|
* signo - The signal number to send. If 'signo' is zero, no signal is
|
|
* sent, but all error checking is performed.
|
|
*
|
|
* Returned Value:
|
|
* On success the signal was send and zero is returned. On error -1 is
|
|
* returned, and errno is set one of the following error numbers:
|
|
*
|
|
* EINVAL An invalid signal was specified.
|
|
* EPERM The thread does not have permission to send the
|
|
* signal to the target thread.
|
|
* ESRCH No thread could be found corresponding to that
|
|
* specified by the given thread ID
|
|
* ENOSYS Do not support sending signals to process groups.
|
|
*
|
|
****************************************************************************/
|
|
|
|
int nxsig_tgkill(pid_t pid, pid_t tid, int signo)
|
|
{
|
|
/* If group members are supported then tgkill() differs from kill().
|
|
* kill(), in this case, must follow the POSIX rules for delivery of
|
|
* signals in the group environment. Otherwise, kill(), like tgkill()
|
|
* will just deliver the signal to the thread ID it is requested to use.
|
|
*/
|
|
|
|
#ifdef CONFIG_SCHED_HAVE_PARENT
|
|
FAR struct tcb_s *rtcb = this_task();
|
|
#endif
|
|
siginfo_t info;
|
|
int ret;
|
|
|
|
/* Make sure that the signal is valid */
|
|
|
|
if (!GOOD_SIGNO(signo))
|
|
{
|
|
ret = -EINVAL;
|
|
goto errout;
|
|
}
|
|
|
|
/* Create the siginfo structure */
|
|
|
|
info.si_signo = signo;
|
|
info.si_code = SI_USER;
|
|
info.si_errno = EINTR;
|
|
info.si_value.sival_ptr = NULL;
|
|
#ifdef CONFIG_SCHED_HAVE_PARENT
|
|
info.si_pid = rtcb->pid;
|
|
info.si_status = OK;
|
|
#endif
|
|
|
|
ret = nxsig_dispatch(tid, &info, pid == (pid_t)-1);
|
|
|
|
errout:
|
|
return ret;
|
|
}
|
|
|
|
/****************************************************************************
|
|
* Name: tgkill
|
|
*
|
|
* Description:
|
|
* The tgkill() system call can be used to send any signal to a thread.
|
|
* See kill() for further information as this is just a simple wrapper
|
|
* around the kill() function.
|
|
*
|
|
* Input Parameters:
|
|
* gid - The id of the task to receive the signal.
|
|
* tid - The id of the thread to receive the signal. Only positive,
|
|
* non-zero values of 'tid' are supported.
|
|
* signo - The signal number to send. If 'signo' is zero, no signal is
|
|
* sent, but all error checking is performed.
|
|
*
|
|
* Returned Value:
|
|
* On success the signal was send and zero is returned. On error -1 is
|
|
* returned, and errno is set one of the following error numbers:
|
|
*
|
|
* EINVAL An invalid signal was specified.
|
|
* EPERM The thread does not have permission to send the
|
|
* signal to the target thread.
|
|
* ESRCH No thread could be found corresponding to that
|
|
* specified by the given thread ID
|
|
* ENOSYS Do not support sending signals to process groups.
|
|
*
|
|
****************************************************************************/
|
|
|
|
int tgkill(pid_t pid, pid_t tid, int signo)
|
|
{
|
|
int ret;
|
|
|
|
ret = nxsig_tgkill(pid, tid, signo);
|
|
if (ret < 0)
|
|
{
|
|
set_errno(-ret);
|
|
ret = ERROR;
|
|
}
|
|
|
|
return ret;
|
|
}
|