3e29996d97
Change every occurence of up_switch_context to use this_task() as the first parameter. "nxsched_add_readytorun" returns "true" if context switch is required. "nxsched_add_readytorun" typically could only switch the assigned/running task to the one which is passed in as parameter. But this is not strictly guaranteed in SMP; if other CPUs tweak with affinities or priorities, it may be possible that the running task after the call is changed, but is some other task from the readytorun list (and it should be, if there is higher priority one available or the affinity of the added task prevents it to be scheduled in, but the previous head of the readytorun list should run. this_task() is always the correct one to switch to, since it always points to the tcb which was just switched in by the nxsched_add_readytorun. This is also a precursor to re-writing the SMP queue logic to remove pending lists for SMP. Signed-off-by: Jukka Laitinen <jukka.laitinen@tii.ae>
120 lines
3.5 KiB
C
120 lines
3.5 KiB
C
/****************************************************************************
|
|
* sched/group/group_continue.c
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed with
|
|
* this work for additional information regarding copyright ownership. The
|
|
* ASF licenses this file to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance with the
|
|
* License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Included Files
|
|
****************************************************************************/
|
|
|
|
#include <nuttx/config.h>
|
|
|
|
#include <sys/types.h>
|
|
#include <stdint.h>
|
|
#include <sched.h>
|
|
#include <pthread.h>
|
|
|
|
#include <nuttx/sched.h>
|
|
|
|
#include "sched/sched.h"
|
|
#include "group/group.h"
|
|
|
|
#ifdef HAVE_GROUP_MEMBERS
|
|
|
|
/****************************************************************************
|
|
* Private Functions
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Name: group_continue_handler
|
|
*
|
|
* Description:
|
|
* Callback from group_foreachchild that handles one member of the group.
|
|
*
|
|
* Input Parameters:
|
|
* pid - The ID of the group member that may be resumed.
|
|
* arg - Unused
|
|
*
|
|
* Returned Value:
|
|
* 0 (OK) always
|
|
*
|
|
****************************************************************************/
|
|
|
|
static int group_continue_handler(pid_t pid, FAR void *arg)
|
|
{
|
|
FAR struct tcb_s *tcb = this_task();
|
|
FAR struct tcb_s *rtcb;
|
|
|
|
/* Resume all threads */
|
|
|
|
rtcb = nxsched_get_tcb(pid);
|
|
if (rtcb != NULL)
|
|
{
|
|
/* Remove the task from waiting list */
|
|
|
|
nxsched_remove_blocked(rtcb);
|
|
|
|
/* Add the task to ready-to-run task list and
|
|
* perform the context switch if one is needed
|
|
*/
|
|
|
|
if (nxsched_add_readytorun(rtcb))
|
|
{
|
|
up_switch_context(this_task(), tcb);
|
|
}
|
|
}
|
|
|
|
/* Always return zero. We need to visit each member of the group */
|
|
|
|
return OK;
|
|
}
|
|
|
|
/****************************************************************************
|
|
* Public Functions
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Name: group_continue
|
|
*
|
|
* Description:
|
|
* Resume all members of the task group. This is SIGCONT default signal
|
|
* action logic.
|
|
* Note: this function should used within critical_section
|
|
*
|
|
* Input Parameters:
|
|
* tcb - TCB of the task to be retained.
|
|
*
|
|
* Returned Value:
|
|
* None
|
|
*
|
|
****************************************************************************/
|
|
|
|
int group_continue(FAR struct tcb_s *tcb)
|
|
{
|
|
irqstate_t flags;
|
|
int ret;
|
|
|
|
flags = enter_critical_section();
|
|
ret = group_foreachchild(tcb->group, group_continue_handler, NULL);
|
|
leave_critical_section(flags);
|
|
return ret;
|
|
}
|
|
|
|
#endif /* HAVE_GROUP_MEMBERS */
|