No description
Find a file
Kerogit a3f8b55143 drivers/serial/serial: prevent race conditions on 8-bit architectures
Some code paths in drivers/serial/serial.c load head and tail values
of receive and transmit circular buffers with interrupts enabled,
making it possible that the interrupt handler changes the value.
As noted in the code, this is safe as long as the load itself is atomic.

That is not true for 8bit architectures which fetch the 16-bit values
using two load instructions. If interrupt handler runs between those
two instructions and changes the value, the read returns corrupted data.

This patch introduces CONFIG_ARCH_LDST_16BIT_NOT_ATOMIC configuration
option which is automatically selected for AVR architecture. Based
on this option, head and tail values are reduced to 8-bit length
so the read remains atomic.

Patch was tested by building on rv-virt:nsh - disassembly of functions
from serial.c showed no difference which is correct as Risc-V does
not need to protect reads of these values. There should be no impact
for architectures that do not set the new configuration option.

It was also tested by by custom echo application running on AVR128DA28.

Signed-off-by: Kerogit <kr.git@kerogit.eu>
2025-06-19 10:01:24 -03:00
.github build(deps): bump codelytv/pr-size-labeler from 1.10.2 to 1.10.3 2025-05-30 10:34:23 -03:00
arch drivers/serial/serial: prevent race conditions on 8-bit architectures 2025-06-19 10:01:24 -03:00
audio fs/file: unify prefix about file_xxx api, like file_open, file_ioctl 2025-06-12 18:12:42 +08:00
binfmt libc/elf: rename modlib to libelf 2025-04-11 09:43:22 +08:00
boards arm64/qemu: add config for fastboot tcp 2025-06-19 10:10:01 +08:00
cmake cmake(bugfix):fix VERSION genarator strip error in CMake build 2025-06-18 15:45:30 -04:00
crypto fs/vfs: Separate file descriptors from file descriptions 2025-06-12 18:12:42 +08:00
Documentation docs/qemu-armv8a: add doc for fastboot tcp 2025-06-19 10:10:01 +08:00
drivers drivers/serial/serial: prevent race conditions on 8-bit architectures 2025-06-19 10:01:24 -03:00
dummy build: add initial cmake build system 2023-07-08 13:50:48 +08:00
fs fs/vfs/fs_close.c: avoid double free if CONFIG_FS_NOTIFY is set 2025-06-16 20:23:53 +08:00
graphics style: fix spelling in code comments and strings 2025-05-23 10:48:41 +08:00
include drivers/serial/serial: prevent race conditions on 8-bit architectures 2025-06-19 10:01:24 -03:00
libs libc: Merge lib_vsprintf from lib_libsprintf.c into lib_libvsprintf.c 2025-06-18 09:24:38 +08:00
mm style: fix spelling in code comments and strings 2025-05-23 10:48:41 +08:00
net fs/file: unify prefix about file_xxx api, like file_open, file_ioctl 2025-06-12 18:12:42 +08:00
openamp style: fix spelling in code comments and strings 2025-05-23 10:48:41 +08:00
pass1 Revert "build depend:Revert Make.dep intermediate ddc file" 2024-09-15 19:29:47 +08:00
sched sched/wqueue: Fix windows compilation errors. 2025-06-18 13:57:20 +02:00
syscall sched/gettid: Move thread ID to TLS 2025-04-08 22:53:10 +08:00
tools tools/testbuild.ps1: Windows fix the redirect error stream 2025-06-18 23:14:18 +08:00
video Revert "build depend:Revert Make.dep intermediate ddc file" 2024-09-15 19:29:47 +08:00
wireless Bluetooth SMP: added support for Legacy pairing (MITM) with passkey 2025-05-28 21:49:08 +08:00
.asf.yaml github: master branch protection tune. 2025-05-07 18:37:13 -05:00
.codespell-ignore-lines style: fix spelling in code comments and strings 2025-05-23 10:48:41 +08:00
.codespellrc style: fix spelling in code comments and strings 2025-05-23 10:48:41 +08:00
.gitignore gitignore: add more vim swap files 2025-06-18 15:44:51 -04:00
.gitmessage docs/contributing: Add a commit message template 2025-06-03 17:33:24 +08:00
.pre-commit-config.yaml pre-commit: enable codespell checks 2025-05-05 12:34:39 +08:00
.yamllint
AUTHORS AUTHORS: add Matteo Golin 2025-05-27 20:34:16 +08:00
CMakeLists.txt style: fix spelling in code comments and strings 2025-05-23 10:48:41 +08:00
CONTRIBUTING.md style: fix spelling in code comments and strings 2025-05-23 10:48:41 +08:00
INVIOLABLES.md
Kconfig libc/elf: rename modlib to libelf 2025-04-11 09:43:22 +08:00
LICENSE style: fix spelling in code comments and strings 2025-05-23 10:48:41 +08:00
Makefile tools: migrate to SPDX identifier 2024-09-10 23:11:11 +08:00
NOTICE
README.md Gathering community recommendations 2023-10-28 13:55:56 +08:00
ReleaseNotes Documentation: move ReleaseNotes 2023-09-26 20:41:00 +08:00

POSIX Badge License Issues Tracking Badge Contributors GitHub Build Badge Documentation Badge

Apache NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOSs (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()).

For brevity, many parts of the documentation will refer to Apache NuttX as simply NuttX.

Getting Started

First time on NuttX? Read the Getting Started guide! If you don't have a board available, NuttX has its own simulator that you can run on terminal.

Documentation

You can find the current NuttX documentation on the Documentation Page.

Alternatively, you can build the documentation yourself by following the Documentation Build Instructions.

The old NuttX documentation is still available in the Apache wiki.

Supported Boards

NuttX supports a wide variety of platforms. See the full list on the Supported Platforms page.

Contributing

If you wish to contribute to the NuttX project, read the Contributing guidelines for information on Git usage, coding standard, workflow and the NuttX principles.

License

The code in this repository is under either the Apache 2 license, or a license compatible with the Apache 2 license. See the License Page for more information.